Skip to content

allow cte in CREATE VIEW#2353

Open
jennifersp wants to merge 1 commit intomainfrom
jennifer/view-cte
Open

allow cte in CREATE VIEW#2353
jennifersp wants to merge 1 commit intomainfrom
jennifer/view-cte

Conversation

@jennifersp
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Main PR
covering_index_scan_postgres 561.44/s 549.47/s -2.2%
index_join_postgres 122.50/s 118.55/s -3.3%
index_join_scan_postgres 173.64/s 174.28/s +0.3%
index_scan_postgres 11.06/s 11.13/s +0.6%
oltp_point_select 2267.17/s 2316.25/s +2.1%
oltp_read_only 1656.61/s 1667.76/s +0.6%
select_random_points 107.55/s 105.69/s -1.8%
select_random_ranges 419.36/s 414.34/s -1.2%
table_scan_postgres 10.85/s 10.79/s -0.6%
types_table_scan_postgres 4.91/s 5.02/s +2.2%

@github-actions
Copy link
Contributor

Main PR
Total 42090 42090
Successful 17588 17587
Failures 24502 24503
Partial Successes1 5585 5585
Main PR
Successful 41.7866% 41.7843%
Failures 58.2134% 58.2157%

${\color{red}Regressions (3)}$

limit

QUERY:          CREATE VIEW limit_thousand_v_2 AS SELECT thousand FROM onek WHERE thousand < 995
		ORDER BY thousand OFFSET 10 FETCH FIRST 5 ROWS ONLY;
RECEIVED ERROR: invalid type: bigint (errno 1105) (sqlstate HY000)
QUERY:          CREATE VIEW limit_thousand_v_4 AS SELECT thousand FROM onek WHERE thousand < 995
		ORDER BY thousand FETCH FIRST NULL ROWS ONLY;
RECEIVED ERROR: interface conversion: interface {} is nil, not int64

updatable_views

QUERY:          CREATE VIEW ro_view8 AS SELECT a, b FROM base_tbl ORDER BY a OFFSET 1;
RECEIVED ERROR: invalid type: bigint (errno 1105) (sqlstate HY000)

${\color{lightgreen}Progressions (2)}$

updatable_views

QUERY: CREATE VIEW ro_view7 AS WITH t AS (SELECT a, b FROM base_tbl) SELECT * FROM t;

with

QUERY: CREATE VIEW sums_1_100 AS
WITH RECURSIVE t(n) AS (
    VALUES (1)
UNION ALL
    SELECT n+1 FROM t WHERE n < 100
)
SELECT sum(n) FROM t;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments