httpbeast: option to set reusePort by timotheecour · Pull Request #47 · dom96/httpbeast

timotheecour · 2021-06-27T21:51:45Z

/cc @dom96
the next PR (dom96/jester#278) will allow using this in jester

dom96

I guess we are relying on the OS complaining about a port being reused without reusePort enabled? Can we add a nicer error message for that case?

dom96 · 2021-07-01T21:57:37Z

src/httpbeast.nim

+      # processes bind to same address/port. We use an Option to avoid
+      # breaking code that relies on `Settings(port: port)`


hm, I think we can live with this breakage. initSettings should be used anyway.

it's in the wild though... in fact, 1st version of this didn't use an Option and it broke some code. Other than that, i agree that initSettings should be used.

note that the recommended way (initSettings) remains clean (no Option used there), so if anything, this is an implementation detail.

timotheecour · 2021-07-01T22:30:34Z

I guess we are relying on the OS complaining about a port being reused without reusePort enabled? Can we add a nicer error message for that case?

yes, I can make a separate PR to add context info (in particular port) in std/net.bindAddr; this can be done independently of this PR (the change belongs in stdlib)

To add more context to this PR, jester.newSettings sets reusePort = false, but this flag (until this PR) wasn't honored:

before PR:

suppose some service already runs in port 5000 (that you may be unaware of, or that might bind right before you launch your new service); then your run:
nim r tests/example.nim
it doesn't fail, but if you run curl http://0.0.0.0:5000, it may send requests to the 1st running server instead of the one you just created, which is not a sane default.

after PR:

it now honors reusePort = false (which is the default set in jester.newSettings, which is a good default), and nim r tests/example.nim will fail with:

/Users/timothee/git_clone/nim/jester/tests/example.nim(3) example
/Users/timothee/git_clone/nim/jester/jester.nim(497) serve
/Users/timothee/git_clone/nim/httpbeast/src/httpbeast.nim(488) run
/Users/timothee/git_clone/nim/httpbeast/src/httpbeast.nim(325) eventLoop
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/net.nim(963) bindAddr
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/includes/oserr.nim(94) raiseOSError
Error: unhandled exception: Address already in use [OSError]

it's easy to see by runnning nim r tests/example.nim in 2 tabs.

future work

I'd recommend changing the default in httpbeast too (matching the default in jester which is saner):

server.setSockOpt(OptReusePort, settings.reusePort.get(true))
=>
server.setSockOpt(OptReusePort, settings.reusePort.get(false))

(i can do this in this PR too but it'd be a breaking change so i'd recommend doing it in another PR instead; at least now, users have a choice)

timotheecour · 2021-07-02T00:52:21Z

@dom96 PTAL

raising when numThreads>1 and reusePort = false just causes more complications, so see PR for what I did instead.

src/httpbeast.nim

Squashed commit of the following: commit 43ee8c3 Author: Dominik Picheta <dominikpicheta@gmail.com> Date: Fri Jul 2 21:50:46 2021 +0100 Fix `run`. commit 804d42c Author: Dominik Picheta <dominikpicheta@googlemail.com> Date: Fri Jul 2 21:42:03 2021 +0100 Update src/httpbeast.nim commit eca38f9 Author: Dominik Picheta <dominikpicheta@googlemail.com> Date: Fri Jul 2 21:40:22 2021 +0100 Update src/httpbeast.nim commit c316b87 Author: Dominik Picheta <dominikpicheta@googlemail.com> Date: Fri Jul 2 21:36:33 2021 +0100 Apply suggestions from code review commit e08209b Author: Timothee Cour <timothee.cour2@gmail.com> Date: Thu Jul 1 17:02:43 2021 -0700 ignore reusePort when running with multiple threads for now commit 64310f4 Author: Timothee Cour <timothee.cour2@gmail.com> Date: Sun Jun 27 15:42:52 2021 -0700 fix tests (use an Option to make code backward compatible) commit d6564d0 Author: Timothee Cour <timothee.cour2@gmail.com> Date: Sun Jun 27 14:52:39 2021 -0700 bump version commit 39b93cf Author: Timothee Cour <timothee.cour2@gmail.com> Date: Wed Apr 17 10:09:08 2019 -0700 httpbeast: option to set reusePort

dom96 · 2021-07-02T20:54:57Z

Sorry, I prefer for this stuff to be explicit. So I changed things.

timotheecour force-pushed the pr_httpbeast_reusePort branch from fd126cf to 303e30c Compare June 27, 2021 21:53

timotheecour mentioned this pull request Jun 27, 2021

allow forwarding reusePort; use asynctools instead of fork now that PR was merged dom96/jester#278

Open

dom96 requested changes Jul 1, 2021

View reviewed changes

timotheecour added 4 commits July 1, 2021 17:02

httpbeast: option to set reusePort

39b93cf

bump version

d6564d0

fix tests (use an Option to make code backward compatible)

64310f4

ignore reusePort when running with multiple threads for now

e08209b

timotheecour force-pushed the pr_httpbeast_reusePort branch from a29b94f to e08209b Compare July 2, 2021 00:02

dom96 approved these changes Jul 2, 2021

View reviewed changes

src/httpbeast.nim Outdated Show resolved Hide resolved

src/httpbeast.nim Outdated Show resolved Hide resolved

src/httpbeast.nim Show resolved Hide resolved

src/httpbeast.nim Outdated Show resolved Hide resolved

src/httpbeast.nim Outdated Show resolved Hide resolved

Apply suggestions from code review

c316b87

dom96 reviewed Jul 2, 2021

View reviewed changes

src/httpbeast.nim Outdated Show resolved Hide resolved

Update src/httpbeast.nim

eca38f9

dom96 reviewed Jul 2, 2021

View reviewed changes

src/httpbeast.nim Outdated Show resolved Hide resolved

Update src/httpbeast.nim

804d42c

dom96 closed this Jul 2, 2021

timotheecour mentioned this pull request Jul 15, 2021

replace reusePort by failOnExistingPort, simpler state (single bool), no TOCTOU for numThreads=1 #53

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

httpbeast: option to set reusePort#47

httpbeast: option to set reusePort#47
timotheecour wants to merge 7 commits intodom96:masterfrom
timotheecour:pr_httpbeast_reusePort

timotheecour commented Jun 27, 2021 •

edited

Loading

Uh oh!

dom96 left a comment

Uh oh!

dom96 Jul 1, 2021

Uh oh!

timotheecour Jul 1, 2021 •

edited

Loading

Uh oh!

timotheecour commented Jul 1, 2021 •

edited

Loading

Uh oh!

timotheecour commented Jul 2, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dom96 commented Jul 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		# processes bind to same address/port. We use an Option to avoid
		# breaking code that relies on `Settings(port: port)`

Conversation

timotheecour commented Jun 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dom96 left a comment

Choose a reason for hiding this comment

Uh oh!

dom96 Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

timotheecour Jul 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timotheecour commented Jul 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

before PR:

after PR:

future work

Uh oh!

timotheecour commented Jul 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dom96 commented Jul 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

timotheecour commented Jun 27, 2021 •

edited

Loading

timotheecour Jul 1, 2021 •

edited

Loading

timotheecour commented Jul 1, 2021 •

edited

Loading

timotheecour commented Jul 2, 2021 •

edited

Loading