Merged
Conversation
Owner
|
Can you rebase so we can get a CI run? |
Contributor
Author
|
Rebased; let me know if it looks good. |
Owner
|
Thanks! Although seems the PR includes my commit, not sure what happened there |
dom96
approved these changes
Jun 13, 2022
Owner
dom96
left a comment
dom96
left a comment
There was a problem hiding this comment.
Overall looks good. Just need slight change to be backwards compatible
dom96
reviewed
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #269 (includes #267 because it relies on the testing changes included there)
nimble testdoesn't work for me because of some of the other dependencies failing (as noted in #263), but I've tested the change and seen the added test pass.