Conversation
Introduce a theme module with semantic color aliases derived from 7 base constants, replacing ~100 scattered hardcoded Color::* values. Add --no-color flag and NO_COLOR env var support (https://no-color.org).
- Add Display impl for TcpState, deduplicating state name mapping - Extract NONE_PLACEHOLDER constant in ui.rs (15 scattered instances) - Replace magic port literals with named constants in DPI module - Standardize lock handling to .expect() with descriptive messages - Remove leftover Firefox-specific debug logging from ui.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.