Open
Conversation
Contributor
edewaele
commented
Jul 6, 2015
edewaele
commented
- POIs are missing address information #31 when the POI lacks address information, a request is sent to Nominatim for retrieving the address
- Popup title must be the same as POI label #47 the popup title is the same as the POI label
- "Locate" was not translated in the address search box
For the sake of consistency, when no name is provided, the popup title may be taken from "ref" or "operator" as in getName()
For the sake of consistency, when no name is provided, the popup tooltip may be taken from "ref" or "operator" as in getName()
Changed Nomimatim widget so that that it uses the translated string
When a POI does not have street name and house number, the address is obtained from Nominatim
Many website keys are not preceded with the protocol identifier, which must me added in the href
This fixes the last untranslated string in issue dotevo#8
Contributor
Author
|
Hey, anyone there ? |
Owner
|
I will push it to test directory today. |
Owner
|
Why you do not use ajax? Like here https://github.com/dotevo/osm24/blob/master/js/main.js#L288 |
Contributor
|
@dotevo good point, I also see no reason for using a proxy (I think this is what you mean?) |
Owner
|
Exactly, I think that can be used but only for Google bot. |
Contributor
Author
|
Even though Webkit authorises such requests, Firefox would not allow a direct ajax request, arguing that this is against "Same-origin" policy. https://github.com/dotevo/osm24/blob/master/js/main.js#L288 does not work with Firefox either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.