Conversation
Added option to increase memory limit Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Added option to increase memory limit Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Added option to increase memory limit Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
arhimede
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What started out as a small feature implementation ended up being a major refactoring.
Let me know if I should split the PR into just the memory limit feature implementation and a different PR with the refactoring.
Key changes:
guzzlehttp/guzzle(used for downloading database archives) with owncurl-based implementationlaminas/laminas-filter(used for extracting database archives) with own implementation using native PHP functionssymfony/filesystem(used for creating/deleting database files) with own implementation using native PHP functionsNote
After the refactoring, the memory limit feature is not quite necessary anymore, because I was able to lower the memory consumption of the
geoip:synchronizecommand down to just 8MNote
Default memory limit is not set to 128M