Fix .NET 5 FileStream compat detection in the test utility project #57288
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-io Issue Details
|
| } | ||
|
|
||
| private static readonly Lazy<bool> _net5CompatFileStream = new Lazy<bool>(() => GetStaticNonPublicBooleanPropertyValue("System.IO.FileStreamHelpers", "UseNet5CompatStrategy")); | ||
| private static readonly Lazy<bool> _net5CompatFileStream = new Lazy<bool>(() => GetStaticNonPublicBooleanPropertyValue("System.IO.Strategies.FileStreamHelpers", "UseNet5CompatStrategy")); |
There was a problem hiding this comment.
Should we make this throw if the type can't be found?
There was a problem hiding this comment.
I was thinking about it, but that would require special handling for when the PlatformDetection type is used to run Full .NET Framework tests. I decided to just add a test instead. Is that OK?
There was a problem hiding this comment.
It's ok.
But I don't fully understand... tests on .NET Framework access _net5CompatFileStream.Value?
There was a problem hiding this comment.
I think Adam meant (please correct me if I'm wrong) that the PlatformDectection class, which contains the _net5CompatFileStream field, is also consumed by some .NET Framework tests. I can see the file can be built for both net60 and net461:
What I do not know is what special handling would be required to make the exception work.
There was a problem hiding this comment.
I've forgotten that it's lazy and only compiled for .NET 4.6.1 (not executed).
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
LGTM. Pending answering the question posted by Stephen.
| } | ||
|
|
||
| private static readonly Lazy<bool> _net5CompatFileStream = new Lazy<bool>(() => GetStaticNonPublicBooleanPropertyValue("System.IO.FileStreamHelpers", "UseNet5CompatStrategy")); | ||
| private static readonly Lazy<bool> _net5CompatFileStream = new Lazy<bool>(() => GetStaticNonPublicBooleanPropertyValue("System.IO.Strategies.FileStreamHelpers", "UseNet5CompatStrategy")); |
There was a problem hiding this comment.
I think Adam meant (please correct me if I'm wrong) that the PlatformDectection class, which contains the _net5CompatFileStream field, is also consumed by some .NET Framework tests. I can see the file can be built for both net60 and net461:
What I do not know is what special handling would be required to make the exception work.
ghost
locked as resolved and limited conversation to collaborators
3 participants
FileStreamHelperswas moved fromSystem.IOtoSystem.IO.Strategiesnamespaceruntime/src/libraries/System.Private.CoreLib/src/System/IO/Strategies/FileStreamHelpers.cs
Lines 7 to 9 in a489488