Open
Conversation
Owner
|
Hey Ethan, thanks for the contributions. Defining steps in the html nodes was something I definitely did want added, but I don't think the exposed method approach should be removed. The idea was very much that it could play with other client-side js apps, with dynamic selector support (not to mention post step callbacks). If you can restore the exposed addStep method I can consider merging, otherwise we're also at risk of breaking backwards compatibility. Also, the getMaximumZIndex method was one of the key requirements, as I don't feel it's safe to rely on a hard-coded value of 1000000 - it's much neater to automatically determine the optimal value. Perhaps this could be a config option with the method fallback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Donovan. I really like what you did with guide.js, especially because it builds around the element, rather than bringing the element out of the page. I added some functionality so the blurbs can be controlled from the HTML instead of JS, and there are some new options to make guide.js a little more flexible.
If you're willing, I'd really appreciate a second set of eyes, and if you like what you see, let's own this OSS together!