Some upgrade work to Simply Lift being appropriate to Lift 3#18
Open
ChrisHagan wants to merge 5 commits intodpp:masterfrom
Open
Some upgrade work to Simply Lift being appropriate to Lift 3#18ChrisHagan wants to merge 5 commits intodpp:masterfrom
ChrisHagan wants to merge 5 commits intodpp:masterfrom
Conversation
…ags. Left content-id in place because the processor in http.Templates seems to match on the attribute prefix [lift|l]. Removed idea and eclipse plugins from base chat project.
…tax in Lift 2.3 (Specifically the promise to support l='Snippet.method')
|
Thanks !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the Lift mailing list, I've cloned out the Simply Lift book and started working through it with the intention of describing the most modern version of the Lift web framework.
I'm checking that the code samples still compile and run, and I've upgraded each build.sbt to a minimal level to run Lift 3. It still uses the same SBT that it originally shipped with, for instance, because that wasn't necessary to run version 3.
I've taken the liberty of correcting a few very minor typos but on the whole I'm trying to preserve the language and tone of the original work because it's excellent for beginners.
Most of the modifications I've made have been very mechanical substitutions of Lift 3 snippet invocation - 'data-lift' instead of class="lift:'. Even though they're both legitimate I really value the practice of removing myself from the CSS class domain and leaving my designer to work, and I want to be steering people into that practice as they take up the framework.
I hope you don't mind. If there's anything at all you want to discuss or steer me back from I'd be thrilled to collaborate.
Oh, I should say: I don't know to use Lyx at ALL, and whatever versions etc. I've managed to install don't seem to want to compile the .lyx files in the project. I'm very gingerly manipulating only the English content in Emacs and hoping that it's easily repairable. If you have any pro tips around appropriate versions or particular setups you found necessary I'm all ears.
Thanks,
c