bent: cmd.Output error may not be ExitError #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From exec.Cmd.Output: "Any returned error will usually be of type
*ExitError." When the binary cannot be found, the error is actually
*exec.Error.
Allow for non-ExitError rather than panicking.
Before:
( GOMAXPROCS=4 GOPATH=/root/bent/scratch/gopath GOOS=linux GOARCH=arm64 GO111MODULE=auto go get -d -t -v github.com/dr2chase/benchmarks/klauspost )
panic: interface conversion: error is *exec.Error, not *exec.ExitError
goroutine 1 [running]:
main.main()
/root/bent/bent.go:562 +0x6e8c
After:
( GOMAXPROCS=4 GOPATH=/root/bent/scratch/gopath GOOS=linux GOARCH=arm64 GO111MODULE=auto go get -d -t -v github.com/egonelbre/spexs2/_benchmark )
There was an error running 'go get': exec: "go": executable file not found in $PATH
DISABLING benchmark spexs2
rm -rf /root/bent/scratch/goroots/Tip/
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From exec.Cmd.Output: "Any returned error will usually be of type
*ExitError." When the binary cannot be found, the error is actually
*exec.Error.
Allow for non-ExitError rather than panicking.
Before:
( GOMAXPROCS=4 GOPATH=/root/bent/scratch/gopath GOOS=linux GOARCH=arm64 GO111MODULE=auto go get -d -t -v github.com/dr2chase/benchmarks/klauspost )
panic: interface conversion: error is *exec.Error, not *exec.ExitError
goroutine 1 [running]:
main.main()
/root/bent/bent.go:562 +0x6e8c
After:
( GOMAXPROCS=4 GOPATH=/root/bent/scratch/gopath GOOS=linux GOARCH=arm64 GO111MODULE=auto go get -d -t -v github.com/egonelbre/spexs2/_benchmark )
There was an error running 'go get': exec: "go": executable file not found in $PATH
DISABLING benchmark spexs2
rm -rf /root/bent/scratch/goroots/Tip/
...