Skip to content

Align ODE dependencies: add Commons Math 3.x alongside 2.x (#92)#98

Open
dyrpsf wants to merge 1 commit intodraeger-lab:masterfrom
dyrpsf:align-ode-deps
Open

Align ODE dependencies: add Commons Math 3.x alongside 2.x (#92)#98
dyrpsf wants to merge 1 commit intodraeger-lab:masterfrom
dyrpsf:align-ode-deps

Conversation

@dyrpsf
Copy link

@dyrpsf dyrpsf commented Jan 6, 2026

This PR implements the first part of issue #92 by ensuring both Commons Math 2.x and 3.x
are available on the classpath:

  • Added org.apache.commons:commons-math3:3.6.1 alongside the existing
    org.apache.commons:commons-math:2.2 in pom.xml.
  • Verified that the project builds with mvn -DskipTests compile and mvn test.
  • mvn dependency:tree "-Dincludes=org.apache.commons:commons-math,org.apache.commons:commons-math3"
    now lists both:
    • org.apache.commons:commons-math:jar:2.2:compile
    • org.apache.commons:commons-math3:jar:3.6.1:compile
  • (Optional, if you ran it) org.simulator.optsolvx.OptSolvXDemo runs without errors.

Copy link
Collaborator

@xts-Michi xts-Michi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently testing and debugging the full implementation of OptSolvX as a new backend for SBSCL (see PR #90 for current status).

Consequently, this PR should remain on hold until the OptSolvX implementation is complete. This ensures the new version of Commons Math can be tested and safely integrated into the new environment. Updating versions now would interfere with current progress and create unnecessary overhead.

@dyrpsf
Copy link
Author

dyrpsf commented Jan 8, 2026

I am currently testing and debugging the full implementation of OptSolvX as a new backend for SBSCL (see PR #90 for current status).

Consequently, this PR should remain on hold until the OptSolvX implementation is complete. This ensures the new version of Commons Math can be tested and safely integrated into the new environment. Updating versions now would interfere with current progress and create unnecessary overhead.

@xts-Michi ,Thanks a lot for the explanation and the pointer to PR #90!

I’m happy to keep this PR on hold until the OptSolvX backend is finished and the new setup for
Commons Math can be tested properly. That makes sense to avoid extra overhead and possible
conflicts with your current work.

Once the OptSolvX implementation is merged and you’re ready to revisit this, please let me know
and I’ll be glad to rebase this branch and adjust anything that’s needed so the Commons Math 3
update integrates cleanly.

@xts-Michi xts-Michi added the on hold Paused until a prerequisite is completed label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on hold Paused until a prerequisite is completed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants