Fix various problems with memory allocation#1
Open
drepper wants to merge 1 commit intodramninjasUMD:masterfrom
Open
Fix various problems with memory allocation#1drepper wants to merge 1 commit intodramninjasUMD:masterfrom
drepper wants to merge 1 commit intodramninjasUMD:masterfrom
Conversation
- virtual destructor in ClockDomain needed to be able to call delete on respective pointers - do not provide incomplete copy of MultiChannelMemorySystem in DRAMSim.h, instead allocate the appropriate header. Among other problems, the copy didn't provide the destructor - in MultiChannelMemorySystem class, add member clockDomainCB to hold pointer to callback. Pass this to clockDomainCrosser and use it to free data structure in destructor - in MultiChannelMemorySystem destructor delete csvOut as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete on respective pointers
DRAMSim.h, instead allocate the appropriate header. Among other
problems, the copy didn't provide the destructor
hold pointer to callback. Pass this to clockDomainCrosser and
use it to free data structure in destructor