-
Notifications
You must be signed in to change notification settings - Fork 21
add functions readXeniumSPE(), readCosmxSPE(), readMerscopeSPE(), and example data #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
… their example datasets in /inst/extdata/* folders
|
Thanks Estella, I think this could be of great help! I just accepted to run the checks, I'll take a look to the code as soon as I can! DArio |
|
@lmweber Hi Lukas, would you like to review? -- Thanks, Estella :D |
|
Hi @estellad , thank you, yes I will have a look at this soon! |
|
Hi @estellad , thanks again for this PR. I'm following up to let you know we are currently in the middle of some discussions about whether to move all the reader functions (including the existing one We (@drighelli @HelenaLC ) will be discussing this and where it is up to some more in a meeting next week, so for now I think it will be better if we wait until after this meeting to finish reviewing this PR. Once we have an agreed plan, we will let you know about where (i.e. which package) we can add these functions and any updates. Does this sound ok to you? |
|
Hi all, updating this discussion to mention that @estellad has now submitted the separate reader package I'll leave this PR / discussion open for now so that we can easily refer to it if we need to while |
|
Also leaving a link to the VisiumIO package here (which is in Bioc-devel now) so we have all the links in one place: https://github.com/waldronlab/VisiumIO |
|
Hi @drighelli Thank you for your upcoming pull request! |
Hi there,
I tried using MoleculeExperiment (ME) read in these new imaging technology data and coerce them to SPE, but the process is a bit long and bulky. Here these 3 functions directly read in the data as SPE at single-cell level (rather than ME at transcript level and then SPE at single-cell level). I also added example data to the /inst/extdata/* folders.
I have not updated the NAMESPACE to export them, so please review first and let me know.
Sincerely,
Estella