refactor: skip notifying for sub accounts with 0 weight#15
Merged
Conversation
|
🚅 Environment sprinkler-pr-15 in Drips App has no services deployed. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the weight validation logic to skip notification for sub-accounts with 0 weight, specifically targeting repo sub-accounts which can legitimately have no splits configured.
- Adds a new utility function to identify repo sub-account driver IDs through bit manipulation
- Updates weight validation logic to silently skip repo sub-accounts with 0 weight instead of treating them as errors
- Refactors the checkTotalWeight function control flow for better clarity
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/isRepoSubAccountDriverId.ts | New utility function to identify repo sub-account drivers by extracting driver type from account ID bits |
| src/index.ts | Updated weight validation to skip notifications for repo sub-accounts with 0 weight and improved control flow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
efstajas
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.