Set PATH in Dockerfile Instead of Clone Script#42
Open
julmb wants to merge 8 commits intodrone:masterfrom
Open
Set PATH in Dockerfile Instead of Clone Script#42julmb wants to merge 8 commits intodrone:masterfrom
julmb wants to merge 8 commits intodrone:masterfrom
Conversation
|
@julmb Thank you very much for this. But, but we can't merge this PR now because currently we don't have a Windows 2022 machine... |
Author
Judging from recent commits, there is now a Server 2022 machine in your CI system. Any chance of getting this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on PR #41.
In
windows/clone.ps1there is a commentThese changes set the PATH in the Dockerfile instead of in the
windows/clone.ps1script.This has the added benefit of enabling the use of the
drone/gitimage to use Git in a pipeline step on Windows (where there are no simple images likealpine/git).