Handle RPC methods with missing options#16
Open
alexpearce wants to merge 1 commit intodrowzy:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the following file
priv/test.proto:This command will fail as of 0.2.0:
Giving:
The command passes if the
GetOthermethod is given an empty method options block:rpc GetOther(TestServiceGetOtherRequest) returns (stream TestServiceGetOtherResponse) {};It seems reasonable to me for a service definition to have some methods with options blocks and some without, so this PR modifies the
GRPCWithOptionsplugin to allow for missing options blocks.This PR lets the command above succeed given the original
priv/test.protofile. Thetmp/test.pb.exfile that results is: