Open
Conversation
Author
Owner
|
Thanks! We still seem to have some failing tests. Can you please look into it? BTW In the future we'd like to have the tests be less brittle. |
Author
|
I 've spent some time trying to figure it out, but I haven't marked any progress yet because I can't seem to reproduce the failure: the tests succeed on all the setups I 've tried and unfortunately travis' log indicates a crash, but no relevant output (just an exit with a non-zero return code when running UmlGraphDoc). I 'd be grateful if you could test it as well since I might be missing something here. Thank you for your time! |
Owner
|
Sadly, I can't test it locally, until we resolve #57. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The majority is just about typos / formatting / rough edges.
Commit 0a71dbf undoes part of what 477d5cc introduced, where UmlDocTest would exit (successfully) before comparing the doclet output to the reference. This unfortunately masked some failing tests (e.g.
testdata/umldoc-ref/gr/spinellis/invoice/gr.spinellis.invoice.dot), where a class relation multiplicity does not appear. These tests now fail.