Skip to content

fix proxy server memory leak#129

Open
ShangSky wants to merge 2 commits intodstotijn:mainfrom
ShangSky:fix-proxy-server-memory-leak
Open

fix proxy server memory leak#129
ShangSky wants to merge 2 commits intodstotijn:mainfrom
ShangSky:fix-proxy-server-memory-leak

Conversation

@ShangSky
Copy link

@ShangSky ShangSky commented Apr 8, 2024

// pkg/proxy/proxy.go
err = http.Serve(l, p)
if err != nil && !errors.Is(err, ErrAlreadyAccepted) {
p.logger.Errorw("Serving HTTP request failed.",
	"error", err)
}

<-clientConnNotify.closed // will block
// pkg/proxy/net.go
func (c *ConnNotify) Close() {
	c.Conn.Close()
	c.closed <- struct{}{} // will block
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant