-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add support for remotely loaded images in RMF #7445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
catalinradoiu
wants to merge
20
commits into
develop
Choose a base branch
from
feature/cradoiu/rmf-image-load
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+359
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r top illustration configuration in the message cta
…r Json remote message mapper
# Conflicts: # android-design-system/design-system/src/main/res/layout/view_remote_message_cta.xml
app/src/main/java/com/duckduckgo/app/browser/remotemessage/RemoteMessageMapper.kt
Show resolved
Hide resolved
android-design-system/design-system/src/main/java/com/duckduckgo/common/ui/view/MessageCta.kt
Show resolved
Hide resolved
...ing-impl/src/main/java/com/duckduckgo/remote/messaging/impl/ui/CardsListRemoteMessageView.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # remote-messaging/remote-messaging-impl/src/main/java/com/duckduckgo/remote/messaging/impl/modal/cardslist/CardsListRemoteMessageView.kt
app/src/main/java/com/duckduckgo/app/browser/remotemessage/RemoteMessageMapper.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1212056917830137?focus=true
Description
This PR adds support for loading remote images in the RMF components. It implements:
Steps to test this PR
Remote Image Loading
UI changes
The image that was loaded is taken from https://staticcdn.duckduckgo.com/remotemessaging/illustrations/image.png
Note
Introduces remote image loading and caching for Remote Messaging Framework (RMF).
imageUrlto multipleRemoteMessage.Contenttypes and propagate via JSON and app/impl mappersMessageCtaand Cards List modal; fall back to existing drawables/animationsview_remote_message_cta.xml,view_promo_message_cta.xml,view_cards_list_remote_message.xml) to include remoteImageViews and barriersRemoteMessageImagePrefetcher(Glide-based) and prefetch evaluated message images inRealRemoteMessagingConfigProcessor; wire via DIimageUrlmapping and prefetch behaviorWritten by Cursor Bugbot for commit 2f828dc. This will update automatically on new commits. Configure here.