Skip to content

Conversation

@catalinradoiu
Copy link
Contributor

@catalinradoiu catalinradoiu commented Jan 7, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1212056917830137?focus=true

Description

This PR adds support for loading remote images in the RMF components. It implements:

  • Updated MessageCta to handle image URLs and display them using Glide
  • Created a RemoteMessageImagePrefetcher to preload remote images for better performance
  • Updated the RemoteMessage model to include imageUrl field in various content types
  • Modified UI layouts to accommodate remote images with proper transitions

Steps to test this PR

Remote Image Loading

  • Verify that remote images load correctly in RMF components (modal and NTP)

UI changes

NTP Modal
Screenshot_20260108_170226 Screenshot_20260108_170149

The image that was loaded is taken from https://staticcdn.duckduckgo.com/remotemessaging/illustrations/image.png


Note

Introduces remote image loading and caching for Remote Messaging Framework (RMF).

  • Add imageUrl to multiple RemoteMessage.Content types and propagate via JSON and app/impl mappers
  • Render remote images with Glide in MessageCta and Cards List modal; fall back to existing drawables/animations
  • Update layouts (view_remote_message_cta.xml, view_promo_message_cta.xml, view_cards_list_remote_message.xml) to include remote ImageViews and barriers
  • Implement RemoteMessageImagePrefetcher (Glide-based) and prefetch evaluated message images in RealRemoteMessagingConfigProcessor; wire via DI
  • Add Glide dependencies to design-system and remote-messaging-impl modules
  • Extend tests/fixtures to cover imageUrl mapping and prefetch behavior

Written by Cursor Bugbot for commit 2f828dc. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@catalinradoiu catalinradoiu changed the title Create poc for loading images with RMF Add support for remotely loaded images in RMF Jan 7, 2026
# Conflicts:
#	android-design-system/design-system/src/main/res/layout/view_remote_message_cta.xml
@catalinradoiu catalinradoiu marked this pull request as ready for review January 8, 2026 16:15
# Conflicts:
#	remote-messaging/remote-messaging-impl/src/main/java/com/duckduckgo/remote/messaging/impl/modal/cardslist/CardsListRemoteMessageView.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant