Skip to content

Conversation

@joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Jan 9, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/1200204095367872/task/1212710755908366?focus=true

Description

  • Updates RealMediaPlayback to match against exempted domains and return false, which in turn sets mediaPlaybackRequiresUserGesture to false for that domain on the WebView.

Steps to test this PR

  • Testing steps in task

Note

Implements domain-based exemptions so media playback won’t require a user gesture on specified domains.

  • Updates RealMediaPlayback to return false when URL matches any exemptedDomains via sameOrSubdomain
  • Extends MediaPlaybackRepository to load and expose exemptedDomains from feature settings JSON (Moshi), refresh on onPrivacyConfigDownloaded, and log parse failures
  • Adds tests for exempted domain behavior and repository settings parsing/updates

Written by Cursor Bugbot for commit 8a4ed44. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joshliebe joshliebe force-pushed the feature/josh/exempt-duck-domains branch 7 times, most recently from 38b0915 to 36cfd22 Compare January 9, 2026 11:13
@joshliebe joshliebe force-pushed the feature/josh/exempt-duck-domains branch from 36cfd22 to 8a4ed44 Compare January 9, 2026 11:24
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested and I can send and receive audio 👍

@joshliebe joshliebe merged commit 65d8e93 into develop Jan 9, 2026
13 checks passed
@joshliebe joshliebe deleted the feature/josh/exempt-duck-domains branch January 9, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants