Malicious Site Protection - Pixels

[alessandroboron]

Task/Issue URL: https://app.asana.com/0/1206329551987282/1207169456840072/f

Description:

This PR adds the pixel events for the malicious site protection feature.

Pixels definition

Note that iframes handling is descoped for the time being.

Steps to test this PR:

Prerequisites
Ensure that isMaliciousSiteProtectionEnabled and shouldDetectMaliciousThreat(forDomain domain: String?) -> Bool defined in MaliciousSiteProtectionFeatureFlags.swift -> return true

Scenario 1 - Navigate to a Malicious site - Phishing

1. Navigate to http://privacy-test-pages.site/security/badware/phishing.html
2. Ensure that Pixel malicious-site-protection_error-page-shown is fired with category phishing.

Scenario 2 - Navigate to a Malicious site - Malware

1. Navigate to http://privacy-test-pages.site/security/badware/malware.html
2. Ensure that Pixel malicious-site-protection_error-page-shown is fired with category malware.

Scenario 3 - Visit Malicious Site - Phishing

1. Navigate to http://privacy-test-pages.site/security/badware/phishing.html
2. Tap the “Advanced” button.
3. Tap the “Accept risk and visit site” button.
4. Ensure that Pixel malicious-site-protection_visit-site is fired with category phishing.

Scenario 4 - Visit Malicious Site - Malware

1. Navigate to http://privacy-test-pages.site/security/badware/malware.html
2. Tap the “Advanced” button.
3. Tap the “Accept risk and visit site” button.
4. Ensure that Pixel malicious-site-protection_visit-site is fired with category malware.

Scenario 3 - Enable/Disable feature in App settings

1. Go to App Settings -> General.
2. Enable/Disable Malicious Site Protection.
3. Ensure that Pixel malicious-site-protection_feature-toggled is fired with parameter newState true / false depending on the setting value.

Definition of Done (Internal Only):

• Does this PR satisfy our Definition of Done?

Copy Testing:

• Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

• Portrait
• Landscape

Device Testing:

• iPhone SE (1st Gen)
• iPhone 8
• iPhone X
• iPhone 14 Pro
• iPad

OS Testing:

• iOS 15
• iOS 16
• iOS 17

Theme Testing:

• Light theme
• Dark theme

---

Internal references:

Software Engineering Expectations
Technical Design Template

[SabrinaTardio]

Pixels are fired as expected!

[SabrinaTardio]

Double checking: No pixel and not implemented yet?

[alessandroboron]

We don’t fire any pixels when the user taps “Leave site” button. Implementation is in its parent which is generic special error handler. It calls leaveSite on its children in case we need to do custom actions. But it’s not the case as we’re not sending pixels.

[SabrinaTardio]

Just double checking: No pixel to send?

[alessandroboron]

As Above

[github-actions]

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

[alessandroboron]

@SabrinaTardio as PixelKit is not ready to be used in iOS I did a small refactoring to use the normal Pixel function on the client. Could you please have a look at this commit 85da6b7 and check you’re happy with it? Thanks!

[SabrinaTardio]

@SabrinaTardio as PixelKit is not ready to be used in iOS I did a small refactoring to use the normal Pixel function on the client. Could you please have a look at this commit 85da6b7 and check you’re happy with it? Thanks!

First of all sorry for not catching this earlier...
I am not managing to build and therefore I cannot test… the changes however make sense
If you have time once everything is shipped would be nice to refactor to user PixelKit (happy to help, assist with it)

[alessandroboron]

@SabrinaTardio as PixelKit is not ready to be used in iOS I did a small refactoring to use the normal Pixel function on the client. Could you please have a look at this commit 85da6b7 and check you’re happy with it? Thanks!

First of all sorry for not catching this earlier... I am not managing to build and therefore I cannot test… the changes however make sense If you have time once everything is shipped would be nice to refactor to user PixelKit (happy to help, assist with it)

Sweet, we can chat once I ship it to make PixelKit iOS friendly :)