Update the plug_crypto dependency to version 2.0.0#193
Update the plug_crypto dependency to version 2.0.0#193omarelb wants to merge 1 commit intoduffelhq:mainfrom
plug_crypto dependency to version 2.0.0#193Conversation
peaceful-james
left a comment
peaceful-james
left a comment
There was a problem hiding this comment.
I am looking forward to this being merged
|
+1 |
1 similar comment
|
+1 |
|
Hey guys! Just curious when it's planned to be merged?) |
|
Hello! Any chance of moving forward with this? Would love to adopt this library in our project but this is preventing us from doing so. |
|
Any chance of getting this change or similar in (plug_crypto is now at 2.1)? |
|
I have switched to using |
|
We have switched to Flop just last week as well 👌 |
| {:inch_ex, "~> 2.0", only: [:dev, :test]}, | ||
| {:postgrex, "~> 0.13", optional: true}, | ||
| {:plug_crypto, "~> 1.2.0"} | ||
| {:plug_crypto, "~> 2.0.0"} |
There was a problem hiding this comment.
I think, we could make it more permissive.
| {:plug_crypto, "~> 2.0.0"} | |
| {:plug_crypto, "~> 1.2.0 or ~> 2.0"} |
As far as I can see in plug_crypto changelog https://github.com/elixir-plug/plug_crypto/blob/main/CHANGELOG.md
The API did not change between the two. The major version got bumped because of the internal algorithm change. However, the transition is smooth.
That means, it can work with both 1.2.x and 2.x.x.
We still keep the 1.2.0 minimum because it fixed an important bug.
12 participants
The outdated dependency was causing my project to be unable to compile.