Infer cursor fields from simple order_by statements. (WIP)

[Nickforall]

This is a version that parses the order fields and their corresponding directions from the Ecto Query struct.

I will rebase this branch and continue as soon as the features of #34 have landed, maybe we can release this together with the new sorting feature?

Todo's

• Dependent on implementation Add ability to have diferent sorting directions per field #34
• Integrate into Config

[bernardd]

Hi @stevedomin - Is there anything I can do to help get this merged in? I'm using this functionality for a feature over in Absinthe and I'd really like to have an official hex package to base that on rather than just pointing it to a fork/branch somewhere.

[Nickforall]

I'll take some time to make this ready for review/merge this week.

[fuelen]

Any progress?

[bernardd]

Hey @stevedomin - this PR is working well for our use case. Is there anything I can do to help get it merged? Sorry to keep hassling you :)

[Nickforall]

It literally doesn't do anything yet. There's a module that resolves cursor fields from order-bys, but its method are not used anywhere in the pagination logic yet, I have to get familiar with the code base again, and I'm travelling right now.

Sorry I couldn't make it work earlier, but a lot of things came in between

[bernardd]

Really? Maybe I'm just using the #34 changes then and...somehow it's doing everything I need anyway. Apologies - apparently I also need to get familiar with the codebase again :)

Edit: Yep, I'm an idiot. Turns out I can more or less make do with #34 (which is already merged) with just a couple of tiny changes to our code. Though it would still be great to get this one going :)

[Nickforall]

It might be that it's sorting by id (that's the default if nothing is given iirc), and that it happens to work for your test case :)

[bernardd]

It might be that it's sorting by id (that's the default if nothing is given iirc), and that it happens to work for your test case :)

It was actually just that I forgot exactly what this one was meant to do and thought "oh, he must do stuff slightly differently" and managed to get away with making a tiny change and it was enough. So yeah, entirely me not paying close enough attention/remembering what this was about in the first place :)