Restore tool-attempt tracking in executeSingleTool() #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overridden executeSingleTool() was not calling parent, which bypassed the toolAttempts counter and ToolMaxTriesException safety net. This allowed an agent to call the same tool infinitely when the context window overflowed and the conversation history was lost. Re-add attempt tracking and max-tries enforcement before tool execution. ToolMaxTriesException is thrown (not caught) so the agent loop terminates. Ref: dx-tooling/sitebuilder-webapp#75 Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restores the
toolAttemptscounter andToolMaxTriesExceptioncircuit breaker inBaseCodingAgent::executeSingleTool().The method overrides the parent without calling
parent::executeSingleTool(), which bypassed the tool-attempt tracking logic. This removed a critical safety net: when the agent's context window overflows and conversation history is lost, the agent can call the same tool infinitely. With this fix,ToolMaxTriesExceptionfires after$toolMaxTries(default: 5) attempts per tool, terminating the runaway loop.Related: dx-tooling/sitebuilder-webapp#75
Changes
ToolMaxTriesExceptionis thrown (not caught by the error-as-result handler)Test plan
php vendor/bin/pest tests/Unit)Made with Cursor