-
Notifications
You must be signed in to change notification settings - Fork 1
Add Gradient Factors #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Gradient Factors #272
Conversation
Unit Test Results3 tests - 3 3 ✅ - 3 0s ⏱️ ±0s Results for commit 1a4262a. ± Comparison against base commit 8674faf. This pull request removes 3 tests.♻️ This comment has been updated with latest results. |
|
This PR has been deployed to a preview site for testing. This site will automatically be deleted when the PR is merged. Last deployed: 2024-07-11T02:17:19Z (UTC) |
Unit Tests Code Coverage
|
|
Problem: Note the sharp drop in ceiling a couple mins from the end of the dive? what explains that? nothing changed at that point other than the continuos ascent? there shouldn't be a big inflection point in the ceiling line. Also the tissue ceiling chart doesn't seem to agree, and for some reason the ceiling becomes deeper around the end. |
|
Another problem:
If you enter 3 mins for maintain, it shows a NDL of 0 sec (which is what I would expect, given that we currently have deco obligations). If you enter 4 mins for maintain, it shows a NDL of > 5 hours. This seems wrong. |
|
Next steps: Have the code spit out some csv files when debugging so that we can more easily inspect the final calculations. TissueNum, DeepestCeiling, time, PN2, PHe, MValue Time, Depth, Ceiling, TargetGF |



Implements #3