Skip to content

Conversation

@dylan-smith
Copy link
Owner

Implements #3

@github-actions
Copy link

github-actions bot commented Jul 9, 2024

Unit Test Results

3 tests   - 3   3 ✅  - 3   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 1a4262a. ± Comparison against base commit 8674faf.

This pull request removes 3 tests.
Chrome_Headless_126_0_6478_126_(Linux_x86_64).DivePlannerService ‑ DivePlannerService 30m for 25 mins on nitrox 32
Chrome_Headless_126_0_6478_126_(Linux_x86_64).DivePlannerService ‑ DivePlannerService NDL accounts for on-gassing during ascent
Chrome_Headless_126_0_6478_126_(Linux_x86_64).DivePlannerService ‑ DivePlannerService with no segments on air

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 9, 2024

This PR has been deployed to a preview site for testing.

This site will automatically be deleted when the PR is merged.

Last deployed: 2024-07-11T02:17:19Z (UTC)

@github-actions
Copy link

github-actions bot commented Jul 9, 2024

UI Test Results

1 files  ±0  9 suites  ±0   3m 10s ⏱️ -4s
3 tests ±0  3 ✅ ±0  0 💤 ±0  0 ❌ ±0 
9 runs  ±0  9 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1a4262a. ± Comparison against base commit 8674faf.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Unit Tests Code Coverage

Code Coverage

Package Line Rate Branch Rate Health
src 100% 100%
src.app 100% 100%
src.app.application-insights-service 12% 100%
src.app.ceiling-chart 0% 0%
src.app.change-depth 0% 0%
src.app.change-gas 0% 0%
src.app.current-stats 0% 0%
src.app.custom-gas-input 0% 0%
src.app.depth-chart 0% 0%
src.app.dive-overview 0% 0%
src.app.dive-plan 0% 0%
src.app.dive-planner-service 57% 49%
src.app.dive-settings 0% 0%
src.app.dive-summary 0% 0%
src.app.end-chart 0% 0%
src.app.error-list 0% 0%
src.app.graph-dialog 0% 0%
src.app.home 0% 0%
src.app.maintain-depth 0% 0%
src.app.new-depth-stats 0% 0%
src.app.new-dive 0% 0%
src.app.new-gas-input 0% 0%
src.app.new-gas-stats 0% 0%
src.app.new-time-stats 0% 0%
src.app.pipes 29% 15%
src.app.po2-chart 0% 0%
src.app.standard-gas-list 0% 0%
src.app.start-gas-stats 0% 0%
src.app.tissues-ceiling-chart 0% 0%
src.app.tissues-phe-chart 0% 0%
src.app.tissues-pn2-chart 0% 0%
src.app.utility 50% 50%
Summary 24% (320 / 1353) 5% (41 / 794)

@dylan-smith
Copy link
Owner Author

Problem:
GF 60/85 (default)
Nitrox32
Descend to 30m
Maintain for 30 min

image

Note the sharp drop in ceiling a couple mins from the end of the dive? what explains that? nothing changed at that point other than the continuos ascent? there shouldn't be a big inflection point in the ceiling line.

Also the tissue ceiling chart doesn't seem to agree, and for some reason the ceiling becomes deeper around the end.

image

@dylan-smith
Copy link
Owner Author

Another problem:

  1. Start Dive: Nitrox 32
  2. Descend to 30m
  3. Maintain for 30 min
  4. Ascend to 6m
  5. Maintain for 3 min
  6. Ascend to 3m
  7. Maintain: ???

If you enter 3 mins for maintain, it shows a NDL of 0 sec (which is what I would expect, given that we currently have deco obligations).

If you enter 4 mins for maintain, it shows a NDL of > 5 hours. This seems wrong.

image

@dylan-smith
Copy link
Owner Author

Next steps: Have the code spit out some csv files when debugging so that we can more easily inspect the final calculations.

TissueNum, DeepestCeiling, time, PN2, PHe, MValue

Time, Depth, Ceiling, TargetGF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants