Enable 64bit opt by default. #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why not?
Owner
|
I suppose this makes sense. I think we had it disabled by default because it broke the MacOS built-in unzip program circa 2015, but hopefully they've fixed this by now... Obviously best practice is to set |
Author
|
Good you mention that, we need to support osx as well, I'll ask one of the other devs with osx to test the 64bit zip file. |
Author
|
This was tested by a colleague of mine, it appears to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why not?
This caused an exception in our environment, I don't see why we would ever want to use the old format for a streaming library (lot's of data is implied).