Merged
Conversation
…nd DTO conversion logic Signed-off-by: Mario Serrano <mario@dynamiasoluciones.com>
…ce action type Signed-off-by: Mario Serrano <mario@dynamiasoluciones.com>
Signed-off-by: Mario Serrano <mario@dynamiasoluciones.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces version 3.4.3 across all modules and significantly enhances the AccountPaymentDTO to support more comprehensive payment information, improving data transfer capabilities for payment-related operations.
- Updated all module versions from 3.4.2 to 3.4.3 for consistency
- Extended
AccountPaymentDTOwith multiple new fields for detailed payment tracking - Implemented
toDTO()method inAccountPaymententity to populate new DTO fields
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sources/pom.xml | Updated parent module version to 3.4.3 |
| sources/api/pom.xml | Updated API module version to 3.4.3 |
| sources/core/pom.xml | Updated core module version and dependencies to 3.4.3 |
| sources/jpa/pom.xml | Updated JPA module version and dependencies to 3.4.3 |
| sources/remote/pom.xml | Updated remote module version and dependencies to 3.4.3 |
| sources/ui/pom.xml | Updated UI module version to 3.4.3 |
| sources/api/src/main/java/tools/dynamia/modules/saas/api/dto/AccountPaymentDTO.java | Added extensive new fields and getters/setters for enhanced payment data |
| sources/core/src/main/java/tools/dynamia/modules/saas/domain/AccountPayment.java | Refactored imports and implemented toDTO() method with proper field mapping |
| sources/ui/src/main/java/tools/dynamia/modules/saas/ui/action/NewAccountPaymentAction.java | Updated action configuration with modern API usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+413
to
+417
| } | ||
|
|
||
|
|
||
| return dto; | ||
| } |
There was a problem hiding this comment.
[nitpick] Remove the extra blank line at line 415 to maintain consistent spacing in the method.
Suggested change
| } | |
| return dto; | |
| } | |
| } | |
| return dto; | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new release (version 3.4.3) across all modules and significantly extends the
AccountPaymentDTOdata transfer object to support more payment-related attributes. It also updates theAccountPaymententity to ensure all new DTO fields are properly populated, and refines some UI action properties for better clarity and consistency.DTO and Entity Enhancements:
AccountPaymentDTO(such asaccount,paymentMethod,couponCode,externalReference,invoiceNumber,reseller, etc.) to capture more detailed payment information. Corresponding getters and setters were implemented. [1] [2] [3] [4]AccountPaymententity'stoDTO()method to populate all new DTO fields, ensuring that related entity data (like payment method, additional service, account, and reseller) is transferred to the DTO.Project Version Updates:
pom.xmlfiles across the project, including parent, API, core, JPA, remote, and UI modules, to mark the new release and ensure dependency consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9]UI Improvements:
NewAccountPaymentActionUI action to usesetShowLabel(true)instead of setting the attribute directly, removed deprecated color/background settings, and set the action type to"success"for better semantic clarity.Code Cleanup:
AccountPayment.javafor clarity and to remove unused wildcard imports.These changes collectively enhance the extensibility and maintainability of the payment module, provide richer data transfer capabilities, and ensure the UI and project structure are up to date with the latest standards.