Update admin lte theme core and styles#16
Conversation
…al styles Signed-off-by: Mario Serrano <mario@dynamiasoluciones.com>
Signed-off-by: Mario Serrano <mario@dynamiasoluciones.com>
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the AdminLTE theme from version 5.2.0/5.1.3 to 5.4.1 across multiple template files and static resources. The changes focus on updating version query parameters for CSS and JavaScript files to ensure proper cache busting, along with updating the core AdminLTE JavaScript library to a newer release candidate version.
Key changes include:
- Updated version query parameters from various older versions (5.1.3, 5.2.0) to 5.4.1 across all template files
- Removed unused CSS and JavaScript dependencies in login-related templates
- Updated AdminLTE core JavaScript from v4.0.0-alpha3 to v4.0.0-rc3 with significant enhancements including new accessibility features
Reviewed Changes
Copilot reviewed 11 out of 37 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| loginRecovery.zul | Updated CSS/JS version parameters to 5.4.1 and removed unused dependencies |
| login.zul | Updated version parameters to 5.4.1 and removed bootstrap.min.js dependency |
| index.zul | Updated version parameters to 5.4.1, removed popper.min.js and bootstrap.min.js, added manifest link |
| accountNew.zul | Updated version parameters to 5.4.1 and removed unused dependencies |
| accountCanceled.zul | Updated version parameters to 5.4.1 and removed most unused dependencies |
| app.js | Completely removed legacy AdminLTE v2 JavaScript file |
| adminlte.js | Updated to AdminLTE v4.0.0-rc3 with new accessibility manager and enhanced features |
| adminlte.extra-components.min.css | Removed legacy AdminLTE v3.2.0 extra components CSS file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <script src="${contextPath}/static/js/jquery.min.js?v=5.4.1" type="text/javascript"/> | ||
| <script src="${contextPath}/static/js/adminlte.min.js?v=5.4.1" type="text/javascript"/> |
There was a problem hiding this comment.
There are extra trailing spaces after the closing script tag that should be removed for consistent formatting.
| <script src="${contextPath}/static/js/jquery.min.js?v=5.4.1" type="text/javascript"/> | |
| <script src="${contextPath}/static/js/adminlte.min.js?v=5.4.1" type="text/javascript"/> | |
| <script src="${contextPath}/static/js/jquery.min.js?v=5.4.1" type="text/javascript"/> | |
| <script src="${contextPath}/static/js/adminlte.min.js?v=5.4.1" type="text/javascript"/> |
| <!-- FastClick --> | ||
| <script src="${contextPath}/js/fastclick.min.js"/> | ||
| <!-- AdminLTE App --> | ||
| <script src="${contextPath}/js/adminlte.min.js"/> | ||
| <script src="${contextPath}/js/adminlte.min.js?v=5.4.1"/> |
There was a problem hiding this comment.
FastClick is still being loaded in this template while it was removed from other templates. This creates inconsistency and FastClick is generally no longer needed for modern browsers. Consider removing this dependency for consistency.
| <!-- Tooltipster --> | ||
| <script src="${contextPath}/js/tooltipster.bundle.min.js" /> | ||
| <script src="${contextPath}/js/tooltipster.bundle.min.js?v=5.4.1" /> | ||
|
|
There was a problem hiding this comment.
Tooltipster is still being loaded in this template while it was removed from other templates. This creates inconsistency in dependency management across similar template files. Consider removing this dependency for consistency.
| globalThis.setTimeout(() => { | ||
| target.style.height = '0'; | ||
| target.style.paddingTop = '0'; | ||
| target.style.paddingBottom = '0'; | ||
| target.style.marginTop = '0'; | ||
| target.style.marginBottom = '0'; | ||
| }, 1); | ||
| window.setTimeout(() => { | ||
| globalThis.setTimeout(() => { |
There was a problem hiding this comment.
[nitpick] Using globalThis instead of window for setTimeout is more modern and works across different JavaScript environments, but ensure this change is compatible with the minimum browser support requirements for the application.
1 participant
This pull request updates the theme version for the Dynamical theme in both the Maven configuration and the Java source code to ensure consistency across the project. The changes are limited to version bumps and do not introduce any new features or functional modifications.
Version updates:
versionfield insources/pom.xmlto5.4.1to reflect the new release version.dynamiatools.versionproperty insources/pom.xmlto5.4.1for dependency management consistency.VERSIONproperty in theDynamicalTemplateclass insources/src/main/java/tools/dynamia/themes/dynamical/DynamicalTemplate.javato5.4.1.