This repository was archived by the owner on Jul 2, 2018. It is now read-only.
make autocomplete usable with Japanese inputs#60
Open
apptaro wants to merge 2 commits intodyve:masterfrom
Open
make autocomplete usable with Japanese inputs#60apptaro wants to merge 2 commits intodyve:masterfrom
apptaro wants to merge 2 commits intodyve:masterfrom
Conversation
Ignore inputs during Japanese IME is active, and evaluate inputs when IME is done.
ghost
assigned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jquery-autocomplete does not work well with Japanese inputs on Firefox. This is caused because Firefox does not fire keydown events when Japanese IME is active. There are two ways to solve the issue: 1) use setTimeout to watch for changes. 2) Ignore inputs during Japanese IME is active, and evaluate inputs when it is done. I fixed the issue with the second option.