Skip to content

Conversation

@JacksonYao287
Copy link
Collaborator

@JacksonYao287 JacksonYao287 commented Dec 24, 2025

this PR also:
1 add more detailed info in gc log
2 make gc data verification configurable.

xiaoxichen
xiaoxichen previously approved these changes Dec 24, 2025
Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except suggesting GCLOGD takes pg_id and shard_id

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 21.79487% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.24%. Comparing base (1746bcc) to head (28182c5).
⚠️ Report is 141 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/homestore_backend/gc_manager.cpp 25.00% 43 Missing and 8 partials ⚠️
...ib/homestore_backend/replication_state_machine.cpp 0.00% 10 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   63.15%   60.24%   -2.92%     
==========================================
  Files          32       35       +3     
  Lines        1900     4593    +2693     
  Branches      204      578     +374     
==========================================
+ Hits         1200     2767    +1567     
- Misses        600     1533     +933     
- Partials      100      293     +193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JacksonYao287
Copy link
Collaborator Author

lgtm except suggesting GCLOGD takes pg_id and shard_id

thanks for the input, I have made this change, ptal

@JacksonYao287 JacksonYao287 force-pushed the fix-delete-marker branch 4 times, most recently from afc3739 to 6ad6c8f Compare December 24, 2025 09:26
xiaoxichen
xiaoxichen previously approved these changes Dec 24, 2025
@xiaoxichen
Copy link
Collaborator

please rebase and fix ut

@JacksonYao287
Copy link
Collaborator Author

please rebase and fix ut

code rebased and bug fixed. the new log of gc will be like this

 [gc_task_id=4, pg_id=1, shard_id=0x1000000000004] 5 valid blobs found in move_from_chunk=73

Copy link
Contributor

@Besroy Besroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacksonYao287
Copy link
Collaborator Author

do we need set verify_blob = true?

https://github.com/eBay/HomeObject/pull/377/changes#diff-1e5351e846693d5e5d1cc75cd9685a6e1d5f29f5a1c8c4a1c438b9cfb594c8f7L37-L38

verify_blob will be true as default

@JacksonYao287 JacksonYao287 merged commit efebdcf into eBay:main Dec 25, 2025
48 of 49 checks passed
@JacksonYao287 JacksonYao287 deleted the fix-delete-marker branch December 25, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants