-
Notifications
You must be signed in to change notification settings - Fork 17
return delete marker for tombstone blob in on_fetch_data #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xiaoxichen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except suggesting GCLOGD takes pg_id and shard_id
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
- Coverage 63.15% 60.24% -2.92%
==========================================
Files 32 35 +3
Lines 1900 4593 +2693
Branches 204 578 +374
==========================================
+ Hits 1200 2767 +1567
- Misses 600 1533 +933
- Partials 100 293 +193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thanks for the input, I have made this change, ptal |
afc3739 to
6ad6c8f
Compare
|
please rebase and fix ut |
48b0c73 to
8e5a6dc
Compare
code rebased and bug fixed. the new log of gc will be like this |
8e5a6dc to
28182c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
verify_blob will be true as default |
this PR also:
1 add more detailed info in gc log
2 make gc data verification configurable.