add a config to allow get_blob without checking traffic ready or not #378
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxichen
reviewed
Dec 25, 2025
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 63.15% 60.18% -2.98%
==========================================
Files 32 35 +3
Lines 1900 4594 +2694
Branches 204 577 +373
==========================================
+ Hits 1200 2765 +1565
- Misses 600 1536 +936
- Partials 100 293 +193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuwmao
reviewed
Dec 25, 2025
Besroy
force-pushed
the
fix_get_blob
branch
3 times, most recently
from
db0e8d5 to
988767b
Compare
1. add a config to allow get_blob without checking traffic ready or not, this is a workaround for 1-replica issue 2. set gc_enable_read_verify true in gc test
JacksonYao287
approved these changes
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for 1-replica issue