Skip to content

Conversation

@yuwmao
Copy link
Contributor

@yuwmao yuwmao commented Feb 26, 2025

New joiner can't vote and is excluded from quorum, so expose to upper layer to perceive this state.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.16%. Comparing base (1a0cef8) to head (a21cae2).
Report is 142 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/replication/repl_dev/raft_repl_dev.cpp 85.71% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
+ Coverage   56.51%   66.16%   +9.64%     
==========================================
  Files         108      109       +1     
  Lines       10300    11257     +957     
  Branches     1402     1532     +130     
==========================================
+ Hits         5821     7448    +1627     
+ Misses       3894     3084     -810     
- Partials      585      725     +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xiaoxichen
xiaoxichen previously approved these changes Feb 27, 2025
JacksonYao287
JacksonYao287 previously approved these changes Feb 27, 2025
Copy link
Contributor

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuwmao yuwmao dismissed stale reviews from JacksonYao287 and xiaoxichen via 20a6bc8 February 28, 2025 09:04
@yuwmao yuwmao force-pushed the replication_status branch from a21cae2 to 20a6bc8 Compare February 28, 2025 09:04
@yuwmao yuwmao force-pushed the replication_status branch from 20a6bc8 to 78fa603 Compare February 28, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants