Skip to content

Breaking: implement asyncio support. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asaf-kali wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Breaking: implement asyncio support. #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions retry/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import asyncio
import logging
import random
import time
import traceback
from functools import partial

Expand All @@ -9,7 +9,7 @@
logging_logger = logging.getLogger(__name__)


def __retry_internal(f, exceptions=Exception, tries=-1, delay=0, max_delay=None, backoff=1, jitter=0,
async def __retry_internal(f, exceptions=Exception, tries=-1, delay=0, max_delay=None, backoff=1, jitter=0,
logger=logging_logger, log_traceback=False, on_exception=None):
"""
Executes a function and retries it if it failed.
Expand All @@ -32,7 +32,7 @@ def __retry_internal(f, exceptions=Exception, tries=-1, delay=0, max_delay=None,
_tries, _delay = tries, delay
while _tries:
try:
return f()
return await f()
Copy link

@tl24 tl24 Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible to conditionally await by calling inspect.isawaitable. Not sure if you can keep the signature without the await, or do an equivalent of an await call using some library function:

  is_async = False
  value = f()
  if inspect.isawaitable(value):
     is_async = True
     value = await value
  return value

is_async could potentially be used in the except block to determine which sleep method to use

Copy link

@laur89 laur89 Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a way to keep the signature intact. And also went with inspect module to find out whether it's dealing with an async function: my implementation

except exceptions as e:
if on_exception is not None:
if on_exception(e):
Expand All @@ -52,7 +52,7 @@ def __retry_internal(f, exceptions=Exception, tries=-1, delay=0, max_delay=None,
if log_traceback:
logger.warning(traceback.format_exc())

time.sleep(_delay)
await asyncio.sleep(_delay)
_delay *= backoff

if isinstance(jitter, tuple):
Expand Down