Draft
Conversation
Member
Author
|
Example of a "drawer" based decorator: [CustomAirshipDecoratorDrawer("Integer")]
internal class IntegerDecorator : AirshipPropertyDrawer {
public override void OnGUI(Rect position, AirshipSerializedValue property, GUIContent label) {
if (property.TryGetDecorator("Range", out List<LuauMetadataDecoratorValue> list))
{
int min = Convert.ToInt32(list[0].value);
int max = Convert.ToInt32(list[1].value);
AirshipEditorGUI.IntSliderProperty(position, label, property, min, max);
}
else {
AirshipEditorGUI.IntProperty(position, label, property);
}
}
}Will be able to add int constrained values to properties, also allows us to add proper implementations for the decorators instead of some of the hacky workarounds we currently have (e.g. for Having all of this logic in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
AirshipPropertyDrawer(The Airship parallel toPropertyDrawer) as well as improves the rendering for elements that could have different sizes (e.g. TextArea based string fields) and better accounts for these in arrays.APIs
AirshipPropertyDrawer(PropertyDrawerequiv.)AirshipDecoratorDrawer(DecoratorDrawerequiv.)AirshipEditorGUI.ArrayPropertyoverloads to includeRect, improved handling to allow custom rectsAirshipEditorGUI.PropertyFieldoverload to allow rect - this also now supports arraysAirshipEditorGUI.GetPropertyHeightto get the heights for properties in AirshipAirshipEditorGUI.GetPropertyLabelto get default labels for properties in AirshipAirshipEditorGUI.GetPropertyControlRectto get the default airship rect for propertiesAirshipEditorGUI.IntSliderPropertyandAirshipEditorGUI.NumberSliderPropertyfor adding sliders for properties