Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Users could hit a
System.NullReferenceExceptioninBridge.StartMicRecordingwhencurrentDevicewas null/stale (for example after device list/name mismatches likeAudio Out).The mic toggle path in settings also triggered recording twice, causing duplicate start attempts/log spam.
Root Cause
SetMicDeviceIndexrelied on direct name matching against UniMic devices; when no match was found,currentDeviceremained null.StartMicRecordingassumedcurrentDevicewas valid.PickMicAndStartRecording()andSetMicrophoneEnabled(true)(which already callsPickMicAndStartRecording()).Changes
airshipBridge.csSetMicDeviceIndex:StartMicRecording:currentDeviceis null/staleResolveMicDeviceByNameResolveFirstMicDeviceAirshipUniVoice.csStartRecording(Mic.Device mic):mic == nullClientSession == nullairship-testbed(#718)MicrophoneSettingsPage.tsclientSettings.PickMicAndStartRecording()call from voice-toggle handlerclientSettings.SetMicrophoneEnabled(true)to perform single start pathBehavior After
Assumptions
Impacted Repos
airshipairship-testbed