Merged
Conversation
added 2 commits
May 20, 2025 13:56
- Updated `GitVersion.yml` to set next version to `6.3.7` and enable commit message incrementing with regex for version bumps. - Refactored `LoadFile` method in `DHLExpressPaperlessEligibilityService.cs` to load JSON data from an embedded resource instead of a file, updating error messages accordingly.
Updated the assembly reference in the resource loading method from `Assembly.GetExecutingAssembly()` to `typeof(CountryPaperlessInfo).Assembly`. This change enhances the accuracy of loading resources by ensuring the correct assembly is used, particularly in scenarios where the executing assembly differs from the one containing the resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor assembly reference for resource loading
Updated the assembly reference in the resource loading method from
Assembly.GetExecutingAssembly()totypeof(CountryPaperlessInfo).Assembly. This change enhances the accuracy of loading resources by ensuring the correct assembly is used, particularly in scenarios where the executing assembly differs from the one containing the resource.