Skip to content

Fix string leak #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
perxjoh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix string leak #14

perxjoh wants to merge 1 commit into from

Conversation

@perxjoh
Copy link

@perxjoh perxjoh commented Jun 16, 2023

All strings from tags are leaked since ll::taglib_tag_free_strings() is not called on drop. Can be reproduced in the existing unit tests.

CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUNNER="valgrind --leak-check=full" cargo test

@perxjoh
Fix string leak
968a316 
All strings from tags are leaked since ll::taglib_tag_free_strings()
is not called on drop.
@sigsmoore sigsmoore mentioned this pull request Feb 1, 2026
Merged
sigsmoore added a commit to sigsmoore/taglib-rust that referenced this pull request Feb 1, 2026
@sigsmoore
Merge pull request #1 from sigsmoore/dev
70916ae 
Replicate sheng's PR [ebassi#15](ebassi#15)

plus some modifications of my own to satisfy the compiler

plus Per Johansson's PR [ebassi#14](ebassi#14) to fix string leaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@perxjoh