Fix crash when using old InterPro data version#295
Open
TheLostLambda wants to merge 6 commits intoebi-pf-team:mainfrom
Open
Fix crash when using old InterPro data version#295TheLostLambda wants to merge 6 commits intoebi-pf-team:mainfrom
TheLostLambda wants to merge 6 commits intoebi-pf-team:mainfrom
Conversation
This is instead of the `no_matches_api` boolean and lays the groundwork for Match API version checking in a future commit.
If the Match API version doesn't match the requested InterPro version, then behave as if `--no-match-api` was set.
An alternative solution here would be moving the Match API version compatibility check to `PREPARE_APPLICATIONS`, but that requires a _lot_ of code restructuring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crash can be reproduced by just setting
--interpro 107.0on the test command:There is a super simple work-around where you can filter out
nullpaths inCOMBINE_MATCHES_LOCALby replacingmembers_matches.collect { it.toString() }with(members_matches - null).collect { it.toString() }, but that felt like a bit of a hacky solution.This PR moves the check for Match API compatibility earlier in the pipeline so we can branch at the same place we would for
--no-matches-api. I think this makes things a bit easier to follow, and it overall shrinks the size of the codebase.I've tried to split the PR into easy-to-understand, self-contained commits to make things easier to review!
Let me know if you have any questions or would like any changes!