feat: Integrate andrewginns/CoreMLPlayer improvements #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izations, and UX clarity (#1) * Add test target and Core ML pipeline coverage * Add test hooks for video detection timing * Fix test imports and Vision observation setup * Fix Vision pipeline test invocation * Link test target to app product * Add bundle loader to test target * Handle compiled model resource in tests * Document expected precisionRecallCurves warning * tests: Coverage before framework improvements * feat: Modernise CoreML loading & inference for stateful models, safer optimizations, and UX clarity * refact: Split test into behaviour related suites * chore: Bump macos and xcode versions * chore: Change CI to only run on PR
Merges 3 commits from andrewginns/CoreMLPlayer: - .mlpackage format support - Major modernization with test suite - .dmg build hotfix This combines our build fix with Andrew's comprehensive improvements: - Test coverage (14 test files) - Stateful model support - Safer optimizations - Better error handling - CI/CD setup Resolved conflict in DetectionView.swift using Andrew's cleaner approach (nil coalescing instead of if-else). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrates 3 commits from andrewginns/CoreMLPlayer:
Combined with our build fix for
DetectionView.swift.Changes
Test plan
🤖 Generated with Claude Code