This repository was archived by the owner on Apr 13, 2023. It is now read-only.
Implement #6172: parameter/argument warning#6183
Open
lucaswerkmeister wants to merge 1 commit intoeclipse-archived:masterfrom
lucaswerkmeister:6172
Open
Implement #6172: parameter/argument warning#6183lucaswerkmeister wants to merge 1 commit intoeclipse-archived:masterfrom lucaswerkmeister:6172
lucaswerkmeister wants to merge 1 commit intoeclipse-archived:masterfrom
lucaswerkmeister:6172
Conversation
If the parameter is not assigned by a BME with the same name, but a different argument is a BME with the same name, issue a warning.
|
Can one of the admins verify this patch? (see README) |
Contributor
Author
|
Thoughts @gavinking / @jvasileff / anyone else? |
Contributor
|
I was skeptical, but encouraged by the results on the SDK. It seems this could be removed or made optional in a future release if it doesn't work out. |
lucaswerkmeister
added a commit
to lucaswerkmeister/ceylon-sdk
that referenced
this pull request
May 5, 2016
- Many, MANY tests were calling assertEquals with the wrong argument order: assertEquals(expected, actual), whereas the correct order with positional arguments is assertEquals(actual, expected). A few of these mistakes were caught by eclipse-archived/ceylon#6183. I attempted to fix them in a way that would be consistent with other tests in the file, so sometimes I swapped the parameters, and sometimes I changed the invocation to use named arguments. - Some tests did manual exception handling instead of using assertThatException. - Some tests could be parameterized (eclipse-archived#159).
lucaswerkmeister
added a commit
to lucaswerkmeister/ceylon-sdk
that referenced
this pull request
May 9, 2016
- Many, MANY tests were calling assertEquals with the wrong argument order: assertEquals(expected, actual), whereas the correct order with positional arguments is assertEquals(actual, expected). A few of these mistakes were caught by eclipse-archived/ceylon#6183. I attempted to fix them in a way that would be consistent with other tests in the file, so sometimes I swapped the parameters, and sometimes I changed the invocation to use named arguments. - Some tests did manual exception handling instead of using assertThatException. - Some tests could be parameterized (eclipse-archived#159). - Some date_* variables were misspelled as data_*.
lucaswerkmeister
referenced
this pull request
Jul 11, 2016
eclipsewebmaster
force-pushed
the
master
branch
from
b50d4cc to
f5e07f3
Compare
Contributor
|
Very interesting idea @lucaswerkmeister. I guess this seems useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the parameter is not assigned by a BME with the same name, but a different argument is a BME with the same name, issue a warning.
Warnings in language module and SDK: gist
Closes #6172.