Skip to content

Conversation

@FriedJannik
Copy link
Member

Description of Changes

Adds CORS Path Pattern for Query Endpoints

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds CORS (Cross-Origin Resource Sharing) support for AAS (Asset Administration Shell) Query Language endpoints across multiple repository and registry services. The change enables cross-origin requests to query endpoints by registering CORS path pattern providers for the /query/** path pattern.

  • Adds CORS configuration beans for query endpoints in all AAS-related services
  • Implements consistent CORS path pattern /query/** across all repositories and registries
  • Follows the existing pattern used for description endpoints

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
SubmodelRepoConfiguration.java Adds CORS provider for submodel repository query endpoints
RestConfiguration.java (submodelregistry) Adds CORS provider for submodel registry query endpoints
ConceptDescriptionRepoConfiguration.java Adds CORS provider for concept description repository query endpoints
AasRepoConfiguration.java Adds CORS provider for AAS repository query endpoints
RestConfiguration.java (aasregistry) Adds CORS provider for AAS registry query endpoints

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@FriedJannik
Copy link
Member Author

Pull Request Overview

This PR adds CORS (Cross-Origin Resource Sharing) support for AAS (Asset Administration Shell) Query Language endpoints across multiple repository and registry services. The change enables cross-origin requests to query endpoints by registering CORS path pattern providers for the /query/** path pattern.

  • Adds CORS configuration beans for query endpoints in all AAS-related services
  • Implements consistent CORS path pattern /query/** across all repositories and registries
  • Follows the existing pattern used for description endpoints

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
SubmodelRepoConfiguration.java Adds CORS provider for submodel repository query endpoints
RestConfiguration.java (submodelregistry) Adds CORS provider for submodel registry query endpoints
ConceptDescriptionRepoConfiguration.java Adds CORS provider for concept description repository query endpoints
AasRepoConfiguration.java Adds CORS provider for AAS repository query endpoints
RestConfiguration.java (aasregistry) Adds CORS provider for AAS registry query endpoints
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Seal Of Approval Thumbs Up GIF

Copy link
Member

@aaronzi aaronzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@aaronzi aaronzi merged commit 7bc060c into eclipse-basyx:main Sep 16, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants