Skip to content

Conversation

@seicke
Copy link
Member

@seicke seicke commented Dec 17, 2025

Description of Changes

Adds ca-certificates installation step to Dockerfiles

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds ca-certificates installation to multiple Dockerfiles across the BaSyx project to ensure SSL/TLS certificate validation works correctly. The changes also introduce HTTP_PROXY and HTTPS_PROXY build arguments to some Dockerfiles.

Key changes:

  • Installation of ca-certificates package in all component Dockerfiles using apt-get
  • Addition of HTTP_PROXY and HTTPS_PROXY arguments to Dockerfiles that didn't previously have them
  • Introduction of USER root directive before package installation, followed by USER nobody in applicable files

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 17 comments.

Show a summary per file
File Description
basyx.submodelservice/basyx.submodelservice.example/Dockerfile Adds USER root, ca-certificates installation, and maintains USER nobody switch
basyx.submodelservice/basyx.submodelservice.component/Dockerfile Adds proxy args to maven-downloader stage and ca-certificates installation with USER directives
basyx.submodelrepository/basyx.submodelrepository.component/Dockerfile Adds USER root, ca-certificates installation, and maintains USER nobody switch
basyx.submodelregistry/basyx.submodelregistry-service-release-log-mongodb/src/main/docker/Dockerfile Adds USER root and ca-certificates installation without switching back to non-root user
basyx.submodelregistry/basyx.submodelregistry-service-release-log-mem/src/main/docker/Dockerfile Adds USER root and ca-certificates installation without switching back to non-root user
basyx.submodelregistry/basyx.submodelregistry-service-release-kafka-mongodb/src/main/docker/Dockerfile Adds USER root and ca-certificates installation without switching back to non-root user
basyx.submodelregistry/basyx.submodelregistry-service-release-kafka-mem/src/main/docker/Dockerfile Adds USER root and ca-certificates installation without switching back to non-root user
basyx.submodelregistry/basyx.submodelregistry-feature-hierarchy-example/src/main/docker/Dockerfile Adds proxy args to both stages and ca-certificates installation without switching back to non-root user; removes trailing newline
basyx.conceptdescriptionrepository/basyx.conceptdescriptionrepository.component/Dockerfile Adds USER root, ca-certificates installation, and maintains USER nobody switch
basyx.aasxfileserver/basyx.aasxfileserver.component/Dockerfile Adds USER root, ca-certificates installation, and maintains USER nobody switch
basyx.aasrepository/basyx.aasrepository.component/Dockerfile Adds USER root, ca-certificates installation, and maintains USER nobody switch
basyx.aasregistry/basyx.aasregistry-service-release-log-mongodb/src/main/docker/Dockerfile Adds USER root and ca-certificates installation without switching back to non-root user
basyx.aasregistry/basyx.aasregistry-service-release-log-mem/src/main/docker/Dockerfile Adds USER root and ca-certificates installation without switching back to non-root user
basyx.aasregistry/basyx.aasregistry-service-release-kafka-mongodb/src/main/docker/Dockerfile Adds USER root and ca-certificates installation without switching back to non-root user
basyx.aasregistry/basyx.aasregistry-service-release-kafka-mem/src/main/docker/Dockerfile Adds proxy args and ca-certificates installation without switching back to non-root user; removes trailing newline
basyx.aasregistry/basyx.aasregistry-feature-hierarchy-example/src/main/docker/Dockerfile Adds proxy args to both stages and ca-certificates installation without switching back to non-root user; removes trailing newline
basyx.aasenvironment/basyx.aasenvironment.component/Dockerfile Adds USER root, ca-certificates installation, and maintains USER nobody switch
basyx.aasdiscoveryservice/basyx.aasdiscoveryservice.component/Dockerfile Adds USER root, ca-certificates installation, and maintains USER nobody switch
basyx.aasdigitaltwinregistry/basyx.digitaltwinregistry.component/Dockerfile Adds proxy args, USER root, ca-certificates installation, and maintains USER nobody switch

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aaronzi aaronzi merged commit 4c556ec into eclipse-basyx:main Dec 18, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants