Simplify calculation of compatible border composite in BorderField #1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptziegler
force-pushed
the
swing-border-lookup
branch
2 times, most recently
from
dbc6fb2 to
6de2b47
Compare
Test Results 2 720 files 2 720 suites 9h 51m 5s ⏱️ Results for commit 39bdf72. ♻️ This comment has been updated with latest results. |
Rather than iterating over a list of all composite classes, define a simple lookup-table. In addition to being faster, it also avoids having two maintain two lists of composites; One for the BorderField and one for the BorderDialog.
ptziegler
force-pushed
the
swing-border-lookup
branch
from
6de2b47 to
39bdf72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than iterating over a list of all composite classes, define a simple lookup-table. In addition to being faster, it also avoids having two maintain two lists of composites; One for the BorderField and one for the BorderDialog.