Skip to content

Conversation

@TrackArcher
Copy link

@TrackArcher TrackArcher commented Jan 13, 2026

hi, I created a metadata listener for internet radiostreams with icy protocol. it works for many streams. I tried to optimize it.
I spend way too much time on this lol.
Let me know what you think!

Screenshot_20260113-120204_Jaguar_home

- Implemented `onMetadata` in `BaseMediaService` to extract "Artist - Title" info from ICY, ID3, and Vorbis streams.
- Added a fallback mechanism to periodically check HTTP headers (e.g., `icy-name`, `StreamTitle`) for radio metadata.
- Updated `PlayerControllerFragment` and `TrackInfoDialog` to display the station name alongside dynamic track information.
- Enhanced `TrackInfoDialog` layout to include a dedicated "Station" field for radio tracks.
- Modified `MappingUtil` to preserve station names in media metadata extras.
@TrackArcher
Copy link
Author

TrackArcher commented Jan 13, 2026

#264
it is for this issue, moe stream still didn't work though. it might not use icy.

@eddyizm
Copy link
Owner

eddyizm commented Jan 14, 2026

Hi @TrackArcher Thanks!
I've been busy with the instant mix refactor so I never got to test on your server. I will review this sometime this week but I do see a couple of things I will ask to change. I will let you know.

Did you by any chance get anyone else to test? Maybe we can add this as a prerelease since I can't really test this myself?

@TrackArcher
Copy link
Author

TrackArcher commented Jan 14, 2026

Hi @eddyizm,
No only I tested it. I use it as daily driver now :)
Let me know what should be changed.
A prerelease sounds good to me

@eddyizm
Copy link
Owner

eddyizm commented Jan 14, 2026

Ok that's a good test, I just want to make sure we don't break other functionality so you daily use is great.
Try and bring in the latest changes and I'll get you feedback by the end the week. I think at first glance, those 2 xml files need to be removed as they affect the build and environment.

@TrackArcher
Copy link
Author

TrackArcher commented Jan 14, 2026

the second removed xml files affecting build and enviroment is the patch for playerbottomsheet to show correct radio metadata instead of the station name 2 times. I messed up and can't change the description. it's my first time using github, but I hope it makes sense :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have miscommunicated about these 2 files. I did not actually mean for you to delete them altogether from the repo, which in this PR it does, i just meant for you to not include the changes, eg don't check them in, to the PR>

I'm not sure if i can delete these here but if I can't, we can close this PR, and submit a clean on.

</option>
</component>
<component name="ExternalStorageConfigurationManager" enabled="true" />
<component name="ProjectRootManager" version="2" languageLevel="JDK_21" default="true" project-jdk-name="jbr-21" project-jdk-type="JavaSDK">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you reintroduce these files in your commit and leave them as they are in main/dev branch, it should fix your deleted files in the PR.

<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="CompilerConfiguration">
<bytecodeTargetLevel target="21" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

@eddyizm eddyizm changed the base branch from main to development January 18, 2026 05:46
@eddyizm
Copy link
Owner

eddyizm commented Feb 8, 2026

@TrackArcher Needed some changes before I merged this but now we have some merge conflicts that also need to be resolved. If you can address the changes and then rebase and fix the merge conflicts, I will try and get this merged in and released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants