-
-
Notifications
You must be signed in to change notification settings - Fork 54
radio metadata #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
radio metadata #352
Conversation
- Implemented `onMetadata` in `BaseMediaService` to extract "Artist - Title" info from ICY, ID3, and Vorbis streams. - Added a fallback mechanism to periodically check HTTP headers (e.g., `icy-name`, `StreamTitle`) for radio metadata. - Updated `PlayerControllerFragment` and `TrackInfoDialog` to display the station name alongside dynamic track information. - Enhanced `TrackInfoDialog` layout to include a dedicated "Station" field for radio tracks. - Modified `MappingUtil` to preserve station names in media metadata extras.
|
#264 |
|
Hi @TrackArcher Thanks! Did you by any chance get anyone else to test? Maybe we can add this as a prerelease since I can't really test this myself? |
|
Hi @eddyizm, |
|
Ok that's a good test, I just want to make sure we don't break other functionality so you daily use is great. |
|
the second removed xml files affecting build and enviroment is the patch for playerbottomsheet to show correct radio metadata instead of the station name 2 times. I messed up and can't change the description. it's my first time using github, but I hope it makes sense :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have miscommunicated about these 2 files. I did not actually mean for you to delete them altogether from the repo, which in this PR it does, i just meant for you to not include the changes, eg don't check them in, to the PR>
I'm not sure if i can delete these here but if I can't, we can close this PR, and submit a clean on.
| </option> | ||
| </component> | ||
| <component name="ExternalStorageConfigurationManager" enabled="true" /> | ||
| <component name="ProjectRootManager" version="2" languageLevel="JDK_21" default="true" project-jdk-name="jbr-21" project-jdk-type="JavaSDK"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you reintroduce these files in your commit and leave them as they are in main/dev branch, it should fix your deleted files in the PR.
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project version="4"> | ||
| <component name="CompilerConfiguration"> | ||
| <bytecodeTargetLevel target="21" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
|
@TrackArcher Needed some changes before I merged this but now we have some merge conflicts that also need to be resolved. If you can address the changes and then rebase and fix the merge conflicts, I will try and get this merged in and released soon. |
hi, I created a metadata listener for internet radiostreams with icy protocol. it works for many streams. I tried to optimize it.
I spend way too much time on this lol.
Let me know what you think!