Two Line Lyrics Highlight Surport #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

sffzh wants to merge 6 commits into eddyizm:development from sffzh:dev_fork

+40 −7

sffzh commented Jan 14, 2026

When two consecutive lines in the lyrics have the same timestamp, both lines will be highlighted simultaneously. This is to support the display of lyrics that include translated text.

sffzh and others added 6 commits

January 13, 2026 17:19


          Supports dual-line lyric display (for bilingual lyric files with tran…

02ec85e

…slations).


          stash changes

1058c35


          hightlight the first line only.

699588c


          fix bug: lost the lastest lyrics line

0f18f80


          Merge branch 'main' into dev_fork

080500a


          Merge branch 'development' into dev_fork

736d35b

Owner

eddyizm commented Jan 24, 2026

Hi @sffzh ,
I tested this today and even though I don't have any lyrics with 2 lines, it seems to have broken the single line lyrics.
I tested on the ampache demo server to see the diff between this PR and the current dev build.

eddyizm added bug needs testing labels

Contributor

pgrit commented Jan 25, 2026

If #384 should be merged, this can be quite elegantly re-implemented by:

Continuing the for loop until the first line is found that is not playing, and tracking a second endIndex
https://github.com/pgrit/tempus/blob/7a4d2be7b56eb7b99706450a6247016a7f3ff271/app/src/main/java/com/cappielloantonio/tempo/ui/fragment/PlayerLyricsFragment.java#L307

Doing a range check rather than equality for this bool:
https://github.com/pgrit/tempus/blob/7a4d2be7b56eb7b99706450a6247016a7f3ff271/app/src/main/java/com/cappielloantonio/tempo/ui/fragment/PlayerLyricsFragment.java#L328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug needs testing