Skip to content

feat:Updating storage code to work with django52.#50

Merged
UsamaSadiq merged 2 commits intomasterfrom
muhammadali286/upgrade-storage-django-52
Jan 28, 2026
Merged

feat:Updating storage code to work with django52.#50
UsamaSadiq merged 2 commits intomasterfrom
muhammadali286/upgrade-storage-django-52

Conversation

@muhammadali286
Copy link
Contributor

Issue #49

@muhammadali286 muhammadali286 self-assigned this Oct 24, 2025
@muhammadali286 muhammadali286 marked this pull request as draft October 24, 2025 14:02
@ktyagiapphelix2u
Copy link

@muhammadali286 This PR resolves the issue by updating the storage logic to use the new Django 5.2 API (storages / import_string).

Could you please share your plans or timeline for merging this change?
Once it’s merged, we’ll re-run Datadog checks for RemovedInDjango51Warning to confirm everything is clean.

@AntonOfTheWoods
Copy link

@muhammadali286 , is there a known reason why it couldn't be merged as-is? It's a draft, so it wasn't clear whether there are some known issues that need to be worked out/discussed or not. Thanks!

@muhammadali286
Copy link
Contributor Author

I am making it backward compatible. I am just testing the solution on both Django versions. I will be finalizing it today.

@muhammadali286 muhammadali286 marked this pull request as ready for review October 29, 2025 05:56
@Waleed-Mujahid
Copy link
Member

@muhammadali286 I have tested this branch with release/ulmo.1 and its working as expected. h5p xblock does not work on master branch. Can we merge this ASAP?

Screenshot 2026-01-28 at 4 52 05 PM

@UsamaSadiq UsamaSadiq merged commit b8cf2ba into master Jan 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants