-
Notifications
You must be signed in to change notification settings - Fork 2
Revert "Upgrade to python 3.12" #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR downgrades the Python version from 3.12 to 3.11 across the entire project, updating configuration files, CI/CD workflows, and regenerating all Python dependency files.
Key changes:
- Python version downgraded from 3.12 to 3.11 in all configuration files
- All requirement files regenerated with Python 3.11
- boto3 and botocore package versions downgraded from 1.40.57 to 1.40.56
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tox.ini | Updated tox environment from py312 to py311 |
| .readthedocs.yaml | Changed ReadTheDocs build Python version to 3.11 |
| .github/workflows/upgrade-python-requirements.yml | Updated Python version for requirements upgrade workflow |
| .github/workflows/mysql8-migrations.yml | Updated Python version matrix to 3.11 |
| .github/workflows/ci.yml | Changed Python version matrix and coverage condition to 3.11 |
| requirements/*.txt | Regenerated all requirement files with Python 3.11, includes boto3/botocore downgrades |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # by the following command: | ||
| # | ||
| # make upgrade | ||
| # pip-compile --cert=None --client-cert=None --index-url=None --output-file=requirements/pip_tools.txt --pip-args=None requirements/pip_tools.in |
Copilot
AI
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pip-compile command line in the header has been changed from the expected 'make upgrade' (as seen in other requirement files) to an explicit command with unusual options (--cert=None, --client-cert=None, --index-url=None, --pip-args=None). This suggests the file was not regenerated using the standard 'make upgrade' command defined in the Makefile. The requirements should be regenerated using 'make upgrade' to ensure consistency with the project's build process.
| # pip-compile --cert=None --client-cert=None --index-url=None --output-file=requirements/pip_tools.txt --pip-args=None requirements/pip_tools.in | |
| # make upgrade |
| # by the following command: | ||
| # | ||
| # pip-compile --allow-unsafe --output-file=requirements/pip.txt requirements/pip.in | ||
| # pip-compile --allow-unsafe --cert=None --client-cert=None --index-url=None --output-file=requirements/pip.txt --pip-args=None requirements/pip.in |
Copilot
AI
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pip-compile command line in the header includes non-standard options (--cert=None, --client-cert=None, --index-url=None, --pip-args=None) that are not present in the Makefile's 'upgrade' target. This suggests the file was not regenerated using the standard 'make upgrade' command. The requirements should be regenerated using 'make upgrade' to ensure consistency with the project's build process.
| # pip-compile --allow-unsafe --cert=None --client-cert=None --index-url=None --output-file=requirements/pip.txt --pip-args=None requirements/pip.in | |
| # pip-compile --allow-unsafe --output-file=requirements/pip.txt requirements/pip.in |
Reverts #157