Skip to content

Conversation

@muhammad-ammar
Copy link
Member

Reverts #157

Copilot AI review requested due to automatic review settings November 3, 2025 16:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR downgrades the Python version from 3.12 to 3.11 across the entire project, updating configuration files, CI/CD workflows, and regenerating all Python dependency files.

Key changes:

  • Python version downgraded from 3.12 to 3.11 in all configuration files
  • All requirement files regenerated with Python 3.11
  • boto3 and botocore package versions downgraded from 1.40.57 to 1.40.56

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tox.ini Updated tox environment from py312 to py311
.readthedocs.yaml Changed ReadTheDocs build Python version to 3.11
.github/workflows/upgrade-python-requirements.yml Updated Python version for requirements upgrade workflow
.github/workflows/mysql8-migrations.yml Updated Python version matrix to 3.11
.github/workflows/ci.yml Changed Python version matrix and coverage condition to 3.11
requirements/*.txt Regenerated all requirement files with Python 3.11, includes boto3/botocore downgrades

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# by the following command:
#
# make upgrade
# pip-compile --cert=None --client-cert=None --index-url=None --output-file=requirements/pip_tools.txt --pip-args=None requirements/pip_tools.in
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pip-compile command line in the header has been changed from the expected 'make upgrade' (as seen in other requirement files) to an explicit command with unusual options (--cert=None, --client-cert=None, --index-url=None, --pip-args=None). This suggests the file was not regenerated using the standard 'make upgrade' command defined in the Makefile. The requirements should be regenerated using 'make upgrade' to ensure consistency with the project's build process.

Suggested change
# pip-compile --cert=None --client-cert=None --index-url=None --output-file=requirements/pip_tools.txt --pip-args=None requirements/pip_tools.in
# make upgrade

Copilot uses AI. Check for mistakes.
# by the following command:
#
# pip-compile --allow-unsafe --output-file=requirements/pip.txt requirements/pip.in
# pip-compile --allow-unsafe --cert=None --client-cert=None --index-url=None --output-file=requirements/pip.txt --pip-args=None requirements/pip.in
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pip-compile command line in the header includes non-standard options (--cert=None, --client-cert=None, --index-url=None, --pip-args=None) that are not present in the Makefile's 'upgrade' target. This suggests the file was not regenerated using the standard 'make upgrade' command. The requirements should be regenerated using 'make upgrade' to ensure consistency with the project's build process.

Suggested change
# pip-compile --allow-unsafe --cert=None --client-cert=None --index-url=None --output-file=requirements/pip.txt --pip-args=None requirements/pip.in
# pip-compile --allow-unsafe --output-file=requirements/pip.txt requirements/pip.in

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

@macdiesel macdiesel merged commit 050f021 into master Nov 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants