-
Notifications
You must be signed in to change notification settings - Fork 4
build: updated ubuntu version to latest #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates Ubuntu runner versions in GitHub Actions workflows from specific versions (ubuntu-22.04 and ubuntu-24.04) to ubuntu-latest to use the latest available Ubuntu version.
Key Changes:
- Updated two jobs in
push-docker-images.ymlworkflow fromubuntu-22.04toubuntu-latest - Updated the apparmor validation workflow from
ubuntu-24.04toubuntu-latest
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/push-docker-images.yml |
Updated set-matrix and push jobs to use ubuntu-latest instead of ubuntu-22.04 |
.github/workflows/apparmor-validate.yaml |
Changed the matrix OS configuration from ubuntu-24.04 to ubuntu-latest for apparmor profile validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| profile: | ||
| - filename: openedx_codejail_service.profile | ||
| os: ubuntu-24.04 # apparmor 4 | ||
| os: ubuntu-latest # apparmor 4 |
Copilot
AI
Jan 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is problematic because the apparmor profile specifically requires AppArmor 4 or higher, which is only available in Ubuntu 24.04+. The profile uses AppArmor 4-specific features including the abi <abi/4.0> declaration and attach_disconnected.path flag. The workflow comment at line 12 explicitly states "AppArmor version must be coordinated with ABI specified in profile."
GitHub's ubuntu-latest may not currently point to Ubuntu 24.04, which would cause this workflow to fail or behave incorrectly. The runner should remain pinned to ubuntu-24.04 to ensure the correct AppArmor version is used.
| os: ubuntu-latest # apparmor 4 | |
| os: ubuntu-24.04 # apparmor 4 |
| matrix: | ||
| profile: | ||
| - filename: openedx_codejail_service.profile | ||
| os: ubuntu-24.04 # apparmor 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to remain at 24.04 and not be updated to latest. See comments.
timmc-edx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(See comment on apparmor-validate.)
Description
Updating the latest version of ubuntu
Ticket Reference
https://2u-internal.atlassian.net/browse/BOMS-285