Skip to content

[Snyk] Security upgrade urllib from 3.27.3 to 4.0.0 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
popomore wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade urllib from 3.27.3 to 4.0.0 #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"mkdirp": "^0.5.1",
"mz-modules": "^2.1.0",
"node-homedir": "^2.0.0",
"urllib": "^3.19.3",
"urllib": "^4.0.0",
Copy link

@gemini-code-assist gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Upgrading urllib to a new major version (v4.0.0) is a significant change that addresses the Allocation of Resources Without Limits or Throttling vulnerability. urllib v4 is a rewrite based on undici and drops support for Node.js versions below 16, which is compatible with this project's engines requirement. It also no longer automatically reads HTTP_PROXY environment variables, which is consistent with this project's decision to drop proxy support (as noted in the v3.0.0 changelog). The existing API calls in lib/init_command.js seem compatible. While this is a breaking change, it appears to be safe in the context of this project.

"yargs": "^11.1.0"
},
"devDependencies": {
Expand Down