Apply flow-refinement for receivers even when using getAnnotatedTypeLhs
#434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmdietl
requested changes
Jun 20, 2023
Member
wmdietl
left a comment
wmdietl
left a comment
There was a problem hiding this comment.
Thanks for fixing this long-standing issue!
@Ao-senXiong please chat with @AndrewShf and see whether you two like this solution.
framework/src/main/java/org/checkerframework/framework/type/AnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/framework/type/GenericAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/framework/type/TypeFromExpressionVisitor.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Werner Dietl <wdietl@gmail.com>
AndrewShf
commented
Aug 14, 2023
framework/src/main/java/org/checkerframework/framework/type/GenericAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
Member
Author
addressed |
wmdietl
changed the title
getAnnotatedTypeLHS
wmdietl
changed the title
getAnnotatedTypeLHSgetAnnotatedTypeLHS
wmdietl
requested changes
Sep 26, 2023
Member
wmdietl
left a comment
wmdietl
left a comment
There was a problem hiding this comment.
@AndrewShf Thanks for your work on this!
framework/src/main/java/org/checkerframework/framework/type/GenericAnnotatedTypeFactory.java
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/framework/type/GenericAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/framework/type/GenericAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/framework/type/TypeFromExpressionVisitor.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Werner Dietl <wdietl@gmail.com>
Member
Author
|
Regarding to the question mentioned in the review (#434 (comment)), a new issue is posted here -> #576 |
wmdietl
requested changes
Sep 29, 2023
Member
wmdietl
left a comment
wmdietl
left a comment
There was a problem hiding this comment.
Thanks for the further edits! The renaming was lost?
framework/src/main/java/org/checkerframework/framework/type/TypeFromExpressionVisitor.java
Outdated
Show resolved
Hide resolved
wmdietl
changed the title
getAnnotatedTypeLHSgetAnnotatedTypeLhs
wmdietl
reviewed
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To replace PR opprop#210
getAnnotatedTypeLhswill setuseflowtofalsewhen calculating the type of a tree. We want receiver still get the refined result.